mitodl / edx-platform

The Open edX platform, the software that powers edX!

http://open.edx.org/

GNU Affero General Public License v3.0

6 stars 1 forks source link

fix: hide canvas tab if there is no course ID set in advanced setting #266

Closed arslanashraf7 closed 3 years ago

arslanashraf7 commented 3 years ago

Related Ticket:

182

What this PR does:

It hides the Canvas tab on the instructor dashboard page if there is not Canvas Course Id set in advanced settings of the course in the studio.

How to test:

Set ENABLE_CANVAS_INTEGRATION to true in lms.yml & studio.yml
Set arbitrary values CANVAS_ACCESS_TOKEN and CANVAS_BASE_URL if you'd like
Set Canvas Course Id in the studio and then visit the Instructor Dashboard tab in LMS, You should see the Canvas Tab on the instructor dashboard page.
Unset the Canvas Course Id in the studio and the Canvas tab should no more be visible

More details can be seen on the ticket #182

Screenshots:

When Couse Id is set

Screenshot 2021-06-04 at 6 06 55 PM

When No Course Id is set

Screenshot 2021-06-04 at 6 07 19 PM

arslanashraf7 commented 3 years ago

@HamzaIbnFarooq Thanks for reviewing this.

@pdpinch, Should I merge this PR?