Object has no attribute 'get_metadata'

[shaidar]

This error seems to be triggered quite frequently on different courses since the Maple upgrade.

Internal Server Error: /api/courseware/sequence/block-v1:MITx+18.031r_7+2022_IAP+type@vertical+block@rec2-tab1

AttributeError at /api/courseware/sequence/block-v1:MITx+18.031r_7+2022_IAP+type@vertical+block@rec2-tab1
'VerticalBlockWithMixins' object has no attribute 'get_metadata'

Traceback (most recent call last):
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
   response = get_response(request)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
   response = wrapped_callback(request, *callback_args, **callback_kwargs)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/sentry_sdk/integrations/django/views.py", line 67, in sentry_wrapped_callback
   return callback(request, *args, **kwargs)
 File "/usr/lib/python3.8/contextlib.py", line 75, in inner
   return func(*args, **kwds)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
   return view_func(*args, **kwargs)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/views/generic/base.py", line 70, in view
   return self.dispatch(request, *args, **kwargs)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
   response = self.handle_exception(exc)
 File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
   response = handler(request, *args, **kwargs)
 File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/courseware_api/views.py", line 591, in get
   return Response(sequence.get_metadata(view=view, context=context))

[shaidar]

@pdpinch Can we have someone from Arbisoft spend some time on this as it's being triggered fairly regularly and would be good to address prior to the Spring semester.

[arslanashraf7]

@asadiqbal08 Assigning it to you since you've been working on it.

[asadiqbal08]

Thanks @arslanashraf7 for that.

[asadiqbal08]

Demo: 'VerticalBlockWithMixins' object has no attribute 'get_metadata'

@pdpinch @shaidar Please take a look over the video before reading that comment for better understanding, For code point of view here are some details but I am not sure why such behaviour was required earlier but issue is pretty falls with Learning MFE

Two main things.

1- The following conditions for just making the navigation <Links> , I am not sure why JumpNavMenuItem component is not allowed to be there by adding this check.

2- The changes in the PR that had merged for Link from router to fix path based routing issue. It makes sense to use the <Link> but in React the problem this creates is say you are on /blah, while clicking on your Link will go to /page, clicking on the <a href='page' /> will take you to /blah/page (reference)

And also clicking on anchor <a> earlier was refreshing the page and fetch metadata again so the exception did not occur but in case of <Link path=...> caused this exception to occur as react routes mapping has changed so when the call goes fetch sequences data then the sequenceId here points to vertical+block (bit odd behaviour) and call failed to OpenEdx that is expecting a sequence instead of a vertical usage key.

[pdpinch]

Thanks for sharing the video. That's really helpful.

1. I believe that the edX product team wants to roll out the jump navigation feature slowly over time, but I'm not sure why. Maybe because they are concerned about technical issues, or they are concerned about user response. It's not unusual for them to release features to subsets of users first, to gather feedback.

2. Since you mention @arslanashraf7's PR, can you discuss with him? I believe he was trying to fix the jump navigation so it would work on systems like ours where the MFE is loaded via a path on the same server, instead of unique domain as its configured at edx.org.

[arslanashraf7]

Since you mention @arslanashraf7's PR, can you discuss with him? I believe he was trying to fix the jump navigation so it would work on systems like ours where the MFE is loaded via a path on the same server, instead of unique domain as its configured at edx.org.

Had a discussion with @asadiqbal08. Discussed why that Link was added to support PUBLIC_PATH which wasn't directly supported in anchor tags. Also, proposed a simpler/faster solution to him for using anchor tags but with getConfig().PUBLIC_PATH as a prefix. (This will get us back to how it was working before except that we won't see 404s life before). Something like for Home/sequence/sections breadcrumbs:

<a className="text-primary-500" href={`${getConfig().PUBLIC_PATH}course/${courseId}/${defaultContent.id}`}>
  {defaultContent.label}
</a>

I believe, @asadiqbal08 might add/propose more details of any other possible solutions that might work for us.

[asadiqbal08]

I have created a PR for OpenEdx community to take a look. The solution at the moment is straight forward. I tried to update the routes but it was causing some other problems as you can see in Learning MFE Here as they are updating the History object on basis of several conditions such as for avoiding infinite loop.

Secondly, as @pdpinch mentioned, edX product team wants to roll out the jump navigation feature slowly over time so it make sense to keep the anchor tag logic there as it was earlier and wait for them to use the jump navigation component that seems me much attractive to move.

@arslanashraf7 take a look over the PR and let me know if you have any concerns.

[arslanashraf7]

@asadiqbal08 Mostly looks fine, A similar change like this will be needed for the Course breadcrumb too. Plus, there are some indentation errors that you might take a look at.

[asadiqbal08]

A similar change like this will be needed for the Course breadcrumb too.

Sorry I did not get that

[arslanashraf7]

A similar change like this will be needed for the Course breadcrumb too.

Sorry I did not get that

@asadiqbal08 Sorry, I missed some formatting in my last message for a link, I've updated it now with the link of the code I'm talking about. this is the link. Do this make sense now?

[asadiqbal08]

Can you tell me why this change required below in this file ?

[arslanashraf7]

Can you tell me why this change required below in this file ?

Since we are reverting Link API changes & moving to an alternate solution. That change for Course breadcrumb was also done in the last PR where we moved from using anchor tags to Link. Plus, If you think the router's Link API isn't going to affect Course breadcrumb then don't change. I just wanted to be on safer side.

[asadiqbal08]

I guess we need to revert that link too as validation was complaining about the BrowserRouter.

[pdpinch]

We will need to backport Mike Terry's fixes to maple, in order to fix this in Residential MITx and xPRO:

https://github.com/openedx/build-test-release-wg/issues/129

acceptance criteria

• [ ] PR to backport https://github.com/edx/edx-platform/commit/712380713b8fc3f46bcef1360fdbcf8c3b468208 to maple.master
• [ ] PR to backport https://github.com/openedx/frontend-app-learning/commit/907892e7bb1263d6b9b56d8acc7fe57abd34cbdd to maple.master

[pdpinch]

FYI, this seems to be working on mitxonline. We should go ahead with the backporting to maple.

[pdpinch]

This should be fixed now. We haven't seen any sentry errors in 4 days.

https://sentry.io/organizations/mit-office-of-digital-learning/issues/2873819044/?project=1757731&query=is%3Aunresolved+get_metadata&statsPeriod=14d