mitodl / edx-platform

The Open edX platform, the software that powers edX!
http://open.edx.org/
GNU Affero General Public License v3.0
6 stars 1 forks source link

Canvas Integration: Refactor the cherry-pick commit as per the canvas plugin migration (Nutmeg) #296

Closed arslanashraf7 closed 1 year ago

arslanashraf7 commented 2 years ago

Description

In our initial development of the Canvas Integration Plugin we refactored a major part of the commits into a plugin itself. There were a few things that we couldn't convert to the plugin either because of the lack of edx-platform support or some complex customization.

One part of the refactored commit was the static assets which we couldn't serve through the plugin and kept in the counterpart cherry-pick.

What to do?

With the Nutmeg release, now the platform supports serving the static content (html/JS) right from the plugin. So we need to refactor the the counterpart cherry-pick and remove the code that is being migrated to the plugin in https://github.com/mitodl/open-edx-plugins/pull/54.

The PR should be created against the mitodl/nutmeg branch.

arslanashraf7 commented 2 years ago

@blarghmatey With the new Nutmeg migrations for our two plugins ol-openedx-rapid-response-reports and ol-openedx-canvas-integration there will be changes in cherry-picks for mitx/nutmeg.

The related PRs are at:

For Posterity

Looks like we have already cherry-picked the commits in our mitx/nutmeg branch but after the migration PRs are merged:

Let me know what you think on that.

pdpinch commented 1 year ago

I'm pretty sure we can close this.