Closed Wassaf-Shahzad closed 2 years ago
Merging #314 (71e0d79) into master (e5cd4c1) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 53.32% 53.32%
=======================================
Files 16 16
Lines 1654 1654
Branches 109 109
=======================================
Hits 882 882
Misses 761 761
Partials 11 11
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e5cd4c1...71e0d79. Read the comment docs.
@Wassaf-Shahzad are you saying that we should upstream a change to https://github.com/openedx/frontend-app-learning ?
@Wassaf-Shahzad are you saying that we should upstream a change to https://github.com/openedx/frontend-app-learning ?
This issue can be fixed by creating an upstream to the edx-platform not the learner MFE as I first thought as the issues exists on both sides (Legacy and Learner MFE) I also created a new issue to track this and other variants.
This issue an be reproduced in the QA environment as explained in the above mentioned issue.
TLDR
The size of the content of the modal is smaller than the enforced 80%
height attribute which causes the extra black area to render.
What are the relevant tickets?
Fixes the LMS issue for ticket #308
What's this PR do?
This PR updated the iframe size on modal opening and closing
How should this be manually tested?
This PR can be manually tested by following steps
Screenshots (if appropriate)
(Optional)