search

mitodl / edx-sga

Staff Graded Assignment XBlock for the edX platform
GNU Affero General Public License v3.0
34 stars 109 forks source link

feat: allow to configure upload file size #349

Open ErickMurillo opened 1 year ago

ErickMurillo commented 1 year ago

What are the relevant tickets?

None, it will be useful for users to be able to customize the upload size of documents.

What's this PR do?

This PR is intended to can customize the upload size limit

How should this be manually tested?

Add the STUDENT_FILEUPLOAD_MAX_SIZE variable with the custom size in the config.yml

Example: STUDENT_FILEUPLOAD_MAX_SIZE = 10 * 1000 * 1000 #10MB

pdpinch commented 1 year ago

New settings require an annotation comment, as specified in OEP-17 https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0017-bp-feature-toggles.html

How will this setting interact with file upload size limits set in nginx?

ErickMurillo commented 1 year ago

New settings require an annotation comment, as specified in OEP-17 https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0017-bp-feature-toggles.html

How will this setting interact with file upload size limits set in nginx?

Hi, i just added the settings annotation comments.

About your questions -> In this case, placing the modification in the ingress-nginx is enough, but the idea would be that the Xblock is not a limitation regardless of changes made at other levels.