search

mitodl / edx2bigquery

Tool to convert & load data from edX platform into BigQuery
GNU General Public License v2.0
29 stars 29 forks source link

Path Imports #69

Closed RogerTangos closed 7 years ago

RogerTangos commented 7 years ago

Frequently, in the code, I encounter

from path import path

What is the rationale for this? In Python 2.7 on OSX, this leads to an error:

ImportError: cannot import name path

The workaround is to simply import path.

Does from path import path work on other machines, or is this importing something outside of the standard lib? This must work for someone, but I having a hard time understanding why.

RogerTangos commented 7 years ago

@kunanit - this changed 6 days ago in transfer_logs_to_gs.py. Any insight?

kunanit commented 7 years ago

I noticed this import error too - see Issue #63 for why it happens.

I addressed this in PR #64

RogerTangos commented 7 years ago

Got it. Sorry for not seeing that sooner - I'll go ahead and checkout.