Sorted list of vocabularies inside api - Githubissues

mitodl / lore

Learning Object Repository for Education

https://goo.gl/nDVx4D

GNU Affero General Public License v3.0

16 stars 6 forks source link

Sorted list of vocabularies inside api #892

Closed amir-qayyum-khan closed 8 years ago

amir-qayyum-khan commented 8 years ago

Hi,

fixes https://github.com/mitodl/lore/issues/888

@pdpinch @noisecapella @giocalitri

amir-qayyum-khan commented 8 years ago

@noisecapella can you please tell me what this issue is, is this related to my code? https://travis-ci.org/mitodl/lore/builds/114516877#L404

amir-qayyum-khan commented 8 years ago

Issue fixed @noisecapella ,

noisecapella commented 8 years ago

@pdpinch does this need to be a case insensitive sort? Is case sensitive fine?

noisecapella commented 8 years ago

It looks like the vocabularies are correctly sorted in the API but when a user adds a new vocabulary it gets put at the bottom of the list no matter what its name is. Can you sort the vocabulary list in the javascript too, in the AddTermsComponent?

pdpinch commented 8 years ago

Case insensitive is more user-friendly.

The specific user who requested this seems to have been careful to capitalize all his vocabularies, but the next user may not be so careful.

pwilkins commented 8 years ago

@amir-qayyum-khan Peter asked me to tag you on his recommendation above.

amir-qayyum-khan commented 8 years ago

Done @noisecapella

amir-qayyum-khan commented 8 years ago

Done @noisecapella

coveralls commented 8 years ago

Coverage decreased (-0.04%) to 96.727% when pulling 3618b6c7cc426f6023c280454d4c14c59d5894e9 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

noisecapella commented 8 years ago

Looks good, please remember to squash :+1:

coveralls commented 8 years ago

Coverage decreased (-0.008%) to 96.756% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage decreased (-0.03%) to 96.736% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.

coveralls commented 8 years ago

Coverage increased (+0.002%) to 96.765% when pulling 149063e5871a79ce598a37937c57e36180d016b7 on enhancement/aq/sort_vocab_lrp_mitocw#888 into 81b1cb35f6a5b11c8702604cf2891dff6f8b691e on master.