search

mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Dashboard: Clicking on background of "enroll in new MicroMasters program" modal doesn't close modal #1825

Open j2tausig opened 7 years ago

j2tausig commented 7 years ago

RC Edge Navigate to dashboard Select "enroll in new program" from the header When the "enroll in new MicroMasters program" modal opens, click in background. This should close the modal, but nothing happens.

pdpinch commented 7 years ago

Does this mean the modal can't be closed?

noisecapella commented 7 years ago

You have to click the cancel button to close it. Disabling clicking outside the modal to close it was a workaround for a race condition between the material-ui dialog and the react-select program switcher

noisecapella commented 7 years ago

Here's the PR which added this bug: https://github.com/mitodl/micromasters/pull/1000 The race condition: https://github.com/JedWatson/react-select/issues/532

pdpinch commented 7 years ago

I think this is the same issue?

https://sentry.io/mit-office-of-digital-learning/micromasters/issues/208617328/

In any case, it may be moot when we switch to the sidebar navigation.

pdpinch commented 6 years ago

There were some workarounds posted at https://github.com/JedWatson/react-select/issues/532#issuecomment-273305208 but the original issue is still open.