Open singingwolfboy opened 7 years ago
Is this a user-facing error? Do you know if this is a regression?
It's user-facing in the sense that a user could discover it, but I don't think it's preventing users from doing anything on the production site. I discovered this bug while trying to manually test a pull request related to coupons, but I suspect that I uncovered it because the course price was negative.
However, I should add that this is a totally silent failure in the UI. Workflow:
At the very least, we should display an error message to the user, in the event that something goes wrong like this.
So the only time we've seen this happen is when the course price is negative?
But if we wrote a proper serializer we could return an error message to the user in the case of any 500 error from this API?
So the only time we've seen this happen is when the course price is negative?
Correct. However, I don't know that it couldn't happen with a positive course price.
But if we wrote a proper serializer we could return an error message to the user in the case of any 500 error from this API?
A proper serializer could return an error message, but it wouldn't be displayed to the user unless the Javascript was set up to do so. I just made #2430 to display an error message, independent of the serializer in the backend.
Sentry: https://sentry.io/mit-office-of-digital-learning/micromasters/issues/208583737/
Visiting https://micromasters.mit.edu/api/v0/financial_aid_skip/1/ while logged in triggers a 500 exception on production. Reproducing this locally produces an
AssertionError
with the following error message:Traceback: