search

mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

scrollbar presence / absence causes a spacing mismatch between profile tabs #414

Open alicewriteswrongs opened 8 years ago

alicewriteswrongs commented 8 years ago

The issue occurs when switching between the education and work history tabs, on a screen height that causes a scrollbar to appear on the education tab but not on the work history tab. The scrollbar changes the screen width, so that the margins calculated for the card (<div class='app-media layout-boxed'>) change a slight amount, causing a little visual jump.

I noticed this just now in reviewing https://github.com/mitodl/micromasters/pull/361, not sure if it's a big enough issue to really warrant doing anything about.

pdpinch commented 8 years ago

may be moot now that the footer has pushed us into requiring scrollbars on all the pages.

alicewriteswrongs commented 8 years ago

It still happens on a tall enough screen (my external monitor). I think that it's not that it is fixed by the footer, but that it wasn't that great of a problem in the first place. I'm fine with ignoring it indefinitely, haha.

pdpinch commented 6 years ago

Is this still an issue?

alicewriteswrongs commented 6 years ago

I believe it is, but I don't think we should worry about it, it's very minor