search

mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

Remove mention of edx.org #5231

Closed annagav closed 1 year ago

annagav commented 1 year ago

What are the relevant tickets?

Fix https://github.com/mitodl/micromasters/issues/5226

What's this PR do?

Remove mention of edx.org

How should this be manually tested?

Checkout the dashboard of your learner.

Before:

Screen Shot 2022-10-04 at 11 07 34 AM

After:

Screen Shot 2022-10-04 at 11 07 49 AM
codecov-commenter commented 1 year ago

Codecov Report

Merging #5231 (a00a3b1) into master (6917917) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head a00a3b1 differs from pull request most recent head 6473d14. Consider uploading reports for the commit 6473d14 to get more accurate results

@@           Coverage Diff            @@
##           master    #5231    +/-   ##
========================================
  Coverage   93.73%   93.73%            
========================================
  Files         501      501            
  Lines       23226    23245    +19     
  Branches     1427      961   -466     
========================================
+ Hits        21770    21788    +18     
  Misses       1351     1351            
- Partials      105      106     +1
Impacted Files Coverage Δ
dashboard/api.py 96.42% <ø> (ø)
static/js/factories/dashboard.js 100.00% <ø> (ø)
static/js/components/dashboard/CourseListCard.js 96.00% <100.00%> (ø)
...tic/js/components/dashboard/CourseListCard_test.js 93.56% <100.00%> (+0.03%) :arrow_up:
static/js/util/util.js 98.94% <100.00%> (+<0.01%) :arrow_up:
static/js/util/util_test.js 99.77% <100.00%> (+<0.01%) :arrow_up:
dashboard/utils.py 96.39% <0.00%> (-0.91%) :arrow_down:
courses/models.py 97.51% <0.00%> (+0.49%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

annagav commented 1 year ago

@arslanashraf7 @pdpinch since the courseware backend is individual per course run, in this PR I am determining the backend for this message based on hopefully valid assumption: If at least one course run in the program is on MITx Online, then the message is going to refer to MITx Online. Otherwise, it's edX.

arslanashraf7 commented 1 year ago

@annagav To pace up and get it merged on Tuesday, For my above suggestion, I've created a branch and a commit in it. (This is the commit https://github.com/mitodl/micromasters/commit/fd43d6a4247c3c774c4cf107dc485e4641d57d2d), If this seems feasible you could just cherry-pick this commit into this branch, I've fixed the tests and stuff accordingly. Let me know what you think.