mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

django admin for program letters #5256

Closed pdpinch closed 1 year ago

pdpinch commented 1 year ago

As an admin, it would be convenient to have a django admin for program letters, where I can search and create new ones.

Acceptance Criteria:

arslanashraf7 commented 1 year ago

Since we are working on this, Would it be fine to add another case that I noticed?

So with https://github.com/mitodl/micromasters/pull/5253 merged we have shifted the letters to be visible when active and also validated the existing letters to mark as inactive.

Based on the above, and the existing implementation of the letter generation function checks if a letter already exists before creating a new one. This could be a problem for the letters that already exist but are inactive now and it's possible that the user can complete these program(s) at some point in the future. In that case, we should mark their existing letter as active. So this logic needs to be changed a bit to handle that case.

pdpinch commented 1 year ago

Sure. Please open a new issue.

I think these should be separate PRs, but if you want to put them both into one that’s OK with me.

arslanashraf7 commented 1 year ago

Sure. Please open a new issue. I think these should be separate PRs, but if you want to put them both into one that’s OK with me.

Created https://github.com/mitodl/micromasters/issues/5257