search

mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
28 stars 16 forks source link

Fix mitxonline SSO #5272

Closed collinpreston closed 1 year ago

collinpreston commented 1 year ago

Pre-Flight checklist

What's this PR do?

This resolves an issue that was introduce by https://github.com/mitodl/micromasters/pull/5264. This also cleans up some of the missing app.json entries for mitxonline. It also renames some of the widely used attributes to be more generic.

How should this be manually tested?

  1. Follow the existing documentation to configure micromasters OAuth with edx and mitxonline.
  2. Set MITXONLINE_CALLBACK_URL=http://host.docker.internal:18000/ in your .env file.
  3. Create or update a program and course in micromasters so that it is currently active.
  4. Make sure the course is set as an mitxonline course.
  5. Test the edx oauth configuration by creating a new micromasters user.
  6. Enroll your user into the program from step 2.
  7. Visit the user's dashboard to verify the mitxonline OAuth configuration.
annagav commented 1 year ago

@collinpreston could you describe which issue is this PR solving? I could not find it in the PR that you linked.

collinpreston commented 1 year ago

@collinpreston could you describe which issue is this PR solving? I could not find it in the PR that you linked.

@annagav there was not an issue that was created in Github for this, but this is resolving an issue that exists in the current master branch. Users are able to SSO via edx but the mitxonline OAuth fails when the user is enrolled in an mitxonline associated course run.