Closed arslanashraf7 closed 1 year ago
Merging #5280 (f5e5734) into master (be8a31e) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #5280 +/- ##
=======================================
Coverage 93.64% 93.65%
=======================================
Files 501 501
Lines 23097 23101 +4
Branches 967 967
=======================================
+ Hits 21629 21635 +6
+ Misses 1361 1359 -2
Partials 107 107
Impacted Files | Coverage Δ | |
---|---|---|
micromasters/urls.py | 93.33% <ø> (ø) |
|
micromasters/settings.py | 90.04% <100.00%> (+0.19%) |
:arrow_up: |
micromasters/admin.py | 100.00% <0.00%> (+100.00%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pre-Flight checklist
app.json
What are the relevant tickets?
5267
What's this PR do?
robots.txt
BASE_URL, ROBOTS_CACHE
etcHow should this be manually tested?
robots.txt
file in the projectMICROMASTERS_BASE_URL=http://mm.odl.local:8079
docker-compose build
followed bydocker-compose up
, notice therobots.txt
file doesn't exist anymore in the static directorysites
in Django Admin with a value that matchesMICROMASTERS_BASE_URL
in your .envRules
model underRobots
in Django Admin and notice a rule exists with*
(for all types of robots)Url
and check that it has existing disallowed URLs in thatlocalhost/robots.txt
you should see these added rules in thatUrl
manually, add that to the Rule and notice that it's reflected inlocalhost/robots.txt
Where should the reviewer start?
(Optional)
Any background context you want to provide?
The PR and its contents are inspired by https://github.com/mitodl/mitxpro/pull/681
Screenshots (if appropriate)
What GIF best describes this PR or how it makes you feel?
(Optional)