search

mitodl / micromasters

Portal for learners and course teams to access MITx Micromasters® programs
https://mm.mit.edu
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Execute polyfills et al before application code #554

Open gsidebo opened 8 years ago

gsidebo commented 8 years ago

Right now, if you use Object.entries outside of a class or function definition in one of our application js files (eg: static/js/containers/ProfilePage.js), you'll get a error claiming that 'Object.entries is undefined'. We should figure out a way to run the polyfill code (and any other such global setup) before the code in our application js files

pdpinch commented 7 years ago

@gsidebo @aliceriot is this still an issue?

alicewriteswrongs commented 7 years ago

AFAIK we never fixed it, just came up with a workaround in the PR where it was an issue.

On Nov 4, 2016 9:21 AM, "Peter Pinch" notifications@github.com wrote:

@gsidebo https://github.com/gsidebo @aliceriot https://github.com/aliceriot is this still an issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mitodl/micromasters/issues/554#issuecomment-258429010, or mute the thread https://github.com/notifications/unsubscribe-auth/AF64nIxSQMcnZWQU39Xr9wqBW39JOoMEks5q6zFSgaJpZM4I2yEl .