search

mitodl / mit-learn

BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

set min cpu and memory. also add qdrant container #1845

Closed shanbady closed 1 week ago

shanbady commented 1 week ago

What are the relevant tickets?

Closes https://github.com/mitodl/mit-learn/issues/1843

Description (What does it do?)

updates the default configuration so that codespaces will launch a 4cpu and 16gb memory instance by default. This Pr also updates runServices in devcontainer.json to include the qdrant service.

How can this be tested?

  1. Click this button to open the default options for the main branch Open in GitHub Codespaces
  2. observe that "2-code" is pre-selected as the machine type
  3. Open the launch page for this branch Open Main branch in GitHub Codespaces
  4. see that the "4-core" option is now the default
  5. use the link above and actually launch the codespace for this branch.
  6. once it finishes building and you can access the terminal, confirm the qdrant container is running by curling the qdrant dashboard page curl http://qdrant:6333/dashboard
shanbady commented 1 week ago 
containerEnv

Good idea. I exposed the qdrant port.

re: secrets in the container - interesting I'm going to have to look a bit more into that because right now there are certain secrets that have defaults set via docker-compose.codespaces.yml which pulls in from envs/codespaces.env (which I think do get properly set during build time) in addition to secrets added via github settings. Its possible that some of those are not properly getting forwarded into the container