setting 100px as default width for buttons

mitodl / mit-open

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

setting 100px as default width for buttons #1185

Closed shanbady closed 1 week ago

shanbady commented 1 week ago

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4717

Description (What does it do?)

Sets a min width of 100px for buttons

How can this be tested?

Checkout this branch and ensure all buttons such as the login button have a minimum width of 100px

jonkafton commented 1 week ago

We probably don't want the min width on action and and icon only buttons (e.g. on the LearningResourceCards), though they could use separate treatment from the main Button component, maybe their own component.

The action buttons have their own widths, so minWidth: "auto" in the actionStyles around L305 should fix.

shanbady commented 1 week ago

See Jon's comment.

Please also take a look at the relevant storybook pages... e.g.,

http://localhost:6006/?path=/story/smoot-design-button--action-buttons-showcase

http://localhost:6006/?path=/story/smoot-design-button--buttons-showcase

just to make sure things look reasonable.

thanks. I keep forgetting we have something like this

shanbady commented 1 week ago

@jonkafton

just pushed a fix with your suggestion