Closed abeglova closed 3 days ago
closes https://github.com/mitodl/hq/issues/4728
This replaces the current logic for the resource tabs with data from the new resource_category field
This should be reviewed with https://github.com/mitodl/course-search-utils/pull/117/files which needs to be released first
NA
Run ./manage.py recreate_index --all if you don't have resource_category in your search index
Go to http://localhost:8063/search and verify that the resource tabs work as expected Go to http://localhost:8063/c/unit/ocw and verify that the resource tabs work as expected
This can already be reviewed, however it depends on https://github.com/mitodl/course-search-utils/pull/117 which depends on releasing https://github.com/mitodl/mit-open/pull/1188 and updating axios
Also recreate_index is needs to run on prod before this can be merged so the resource_category field is updated in the search index
DO NOT MERGE UNTIL 1) https://github.com/mitodl/mit-open/pull/1188 is released done 2) recreate_index is run on prod 3) @mitodl/open-api-axios is updated done 4) https://github.com/mitodl/course-search-utils/pull/117 is updated to use the params from the updated @mitodl/open-api-axios done 5) course-search-utils is released with https://github.com/mitodl/course-search-utils/pull/117 6) This pr is updated to point to the released version of course-search-utils instead of a branch This is ready to merge once approved
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4728
Description (What does it do?)
This replaces the current logic for the resource tabs with data from the new resource_category field
This should be reviewed with https://github.com/mitodl/course-search-utils/pull/117/files which needs to be released first
Screenshots (if appropriate):
NA
How can this be tested?
Run ./manage.py recreate_index --all if you don't have resource_category in your search index
Go to http://localhost:8063/search and verify that the resource tabs work as expected Go to http://localhost:8063/c/unit/ocw and verify that the resource tabs work as expected
Additional Context
This can already be reviewed, however it depends on https://github.com/mitodl/course-search-utils/pull/117 which depends on releasing https://github.com/mitodl/mit-open/pull/1188 and updating axios
Also recreate_index is needs to run on prod before this can be merged so the resource_category field is updated in the search index
DO NOT MERGE UNTIL1)https://github.com/mitodl/mit-open/pull/1188 is releaseddone 2)recreate_index is run on prod3)@mitodl/open-api-axios is updateddone 4)https://github.com/mitodl/course-search-utils/pull/117 is updated to use the params from the updated @mitodl/open-api-axiosdone 5)course-search-utils is released with https://github.com/mitodl/course-search-utils/pull/1176)This pr is updated to point to the released version of course-search-utils instead of a branchThis is ready to merge once approved