mitodl / mit-open

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Fix default image height in resource cards #1212

Closed jonkafton closed 4 days ago

jonkafton commented 4 days ago

What are the relevant tickets?

Fixes https://github.com/mitodl/hq/issues/4774

Description (What does it do?)

Provides the image height explicitly - we cannot rely on the height of the image itself to preserve dimensions as the default image is fixed / does not go to Embedly for cropping.

How can this be tested?

Navigate to the dashboard with no profile.

Ensure that the card image heights are equal. The issue was with the default image, so there must be a mixture with some default images for the check to be valid:

(Default image: image).