search

mitodl / mit_lti_flask_sample

a sample LTI provider using the PyLTI library and the Flask framework
23 stars 44 forks source link

Present a more 12 factor app style config.py file #19

Closed carsongee closed 9 years ago

carsongee commented 9 years ago

Show how to set certificates and other secrets using environment variables per http://12factor.net/

pdpinch commented 9 years ago

@carsongee Are there corresponding changes that need to be made to the docs for this, i.e. how to set the environment variables in Heroku?

carsongee commented 9 years ago

I was presuming that would be common knowledge, but you are right, it is probably worth some doc at least point to heroku's docs on it. I'll add that today or early tomorrow.

pdpinch commented 9 years ago

I think @pwilkins or @cshubert can add this to their next pass on the docs, if you don't have the time.

carsongee commented 9 years ago

I do, and have an example .env file for working with foreman, so it would probably save us all time if I did it with this PR.

carsongee commented 9 years ago

I've added the documentation to go along with the change.

pdpinch commented 9 years ago

Thanks @carsongee

@pwilkins @cshubert can you review, time permitting?