search

mitodl / mit_lti_flask_sample

a sample LTI provider using the PyLTI library and the Flask framework
23 stars 44 forks source link

Add deploy to heroku button #24

Closed carsongee closed 9 years ago

carsongee commented 9 years ago

I just verified this works with my devstack. Super neat.

pwilkins commented 9 years ago

If you are not already logged in to Heroku, the app creation script takes you to your personal apps list following your login. Does it make sense to require users to login to Heroku first?

carsongee commented 9 years ago

How can I require them to login to Heroku first? Just suggest it in the doc? I'm guessing this is a bug Heroku will likely fix as it is their ball to fumble, and I would rather not document it as we will likely lose track of the issue. If you feel it is warranted, I'll add a sentence though.

pwilkins commented 9 years ago

Well, the "Deploy..." button simply doesn't do what we want it to do if you have to login to Heroku, though I didn't try to create a new account instead of logging in to my existing account.