search

mitodl / mit_lti_flask_sample

a sample LTI provider using the PyLTI library and the Flask framework
23 stars 44 forks source link

bump python version for heroku #31

Closed njoliat closed 6 years ago

njoliat commented 6 years ago

Heroku doesn't support the Python version given in runtime.txt; trying to deploy results in an error as mentioned here. Bumping the Python version to 2.7.14 seems to resolve the problem.

njoliat commented 6 years ago

(there was a similar issue with uWSGI not building on Heroku, so I bumped the version of that too in requirements.txt.)

amir-qayyum-khan commented 6 years ago

@njoliat unable able to install uWSGI==2.0.13 on osx Failed building wheel for uWSGI

I am tried python 2 and 3

njoliat commented 6 years ago

@amir-qayyum-khan thanks for the reply. the problem is that installation on Heroku (which runs Ubuntu and which I believe is the main target?) seems to require uWSGI to be updated; if I have uWSGI==2.0.7 then I get this error, but if I have uWSGI==2.0.13 then it works.

that being said, I have reverted the uWSGI commit on master so that you can pull just the python update (I can also make a new pull request on a clean branch that doesn't have the commit reversion, if that's better.) I will make a separate pull request with the uWSGI update.