Closed ChristopherChudzicki closed 6 years ago
@jolyonb This is going to be a pretty big PR. I updated the to-do list at the top. No rush at all, but if you want to look at any of it, I consider what's been pushed to be ready-for-review.
My goal will be to finish some of the course demos for comparer_function
s before tomorrow's meetings. (But I probably won't write the website documention for it before the meetings. )
I'm sure this one is going to be huge -- we're catching up on two months' worth of features! I'm going to hold off on looking/making comments until you're done, I think.
I agree that focusing on some course demos for tomorrow's meeting(s?) is probably a good idea.
Can we make a standalone module of comparison functions, rather than having them scattered about randomly?
Can we make a standalone module of comparison functions, rather than having them scattered about randomly?
Sure! This was my original inclination, though MatrixGrader comparer_functions get a few extra utils
.
I much prefer a standalone module. I think we should be able to figure out how to make something that works with the appropriate utils ;-) It can be exposed in a comparers
module.
@jolyonb Ready for review. My version of the demo course and website are update, see PR summary.
rebased to fix merge conflicts
Thanks. I'm going to try to do the programmatic part of this tomorrow morning.
I'm merging this now, and will make updates in a future PR.
MatrixGrader
specify_domain
documentationcomparer_function
sNumericalGrader
course example usingis_between
comparerMatrixGrader
course example using eigenvector/eigenvalue comparerListGrader
eigenvalue/eigenvector comparer demoindex.md
andgetting_starting.md
(there was a lot of overlap)Some of these are very close to done.
My version of the documentation website My version of demo course
Note: I changed the theme to mkdocs-cinder, because I wanted one level deeper on the individual page table of contents. Could explore other themes, but not going to worry about it now.