search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

atan2 #133

Closed jolyonb closed 6 years ago

jolyonb commented 6 years ago

Would be good to have an arctangent function that accepts an x and a y value, capable of returning results in all four quadrants.

ChristopherChudzicki commented 6 years ago

Sure! Is this just “it would be nice” or is there a class you have a specific purpose in mind for? Do you care what the name is? We could overload ‘arctan(...)’ so that except one or two arguments (This is what Mathematica does) or have a separate function.

jolyonb commented 6 years ago

I'm not sure we have the infrastructure to overload a function at this stage? I'm not sure we really need it, either... atan2 is a fine function name (used by various codes). And yes, I have an explicit use for it in computing quantum phases.

jolyonb commented 6 years ago

Resolved by #139