Closed ChristopherChudzicki closed 6 years ago
@jolyonb This is ready for review.
I had to specify pytest-cov version in requirements.txt. Newest version (2.6) dropped support for Python <3.4. We have the most recent version that supports Python 2.7.
https://pytest-cov.readthedocs.io/en/latest/changelog.html#id1
Feel free to mark any unconstructive comments as resolved, btw.
I believe I've just resolved everything except for the adjacent
issue. Just confirm you want that and I can change it, or merge as is.
If we don't break any tests by setting adjacent
to True, then let's go ahead and do it.
Awesome job. This almost feels like it's worthy of a revision number!
Rewrote much of
calc.py
and changed name toexpressions.py
Noteable changes:
I tried to separate parsing and evaluation as much as possible. Usage now looks like:
'x + 5y'
. We used to just say "Unable to parse". Now the expression DOES parse, but we can say "y not allowed directly after number, did you forget*
?"