mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

add arctan2 and curly brace validation #139

Closed ChristopherChudzicki closed 6 years ago

ChristopherChudzicki commented 6 years ago

Edit: This PR addresses #133 and #138

jolyonb commented 6 years ago

Want to update version numbers everywhere to 1.2.1? I think we should also include #138 in a version update.

Otherwise, this looks fine to me. Might suggest adding a couple of simple tests in the functions file where we test the inverse trig functions - arctan2(x, y) == arctan(y/x) type things.

ChristopherChudzicki commented 6 years ago

Sure, I can implement #138 in this PR and add it to changelog. Either later tonight or tomorrow.

I just updated version in README.

I moved the arctan2 tests into their own file because of https://bugs.python.org/issue6835

jolyonb commented 6 years ago

Looks good. Also remember to update __version__ in mitxgraders/version.py

jolyonb commented 6 years ago

All looks good 👍