search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

Updating SingleListGrader to detect missing entries #217

Closed jolyonb closed 5 years ago

jolyonb commented 5 years ago

Adds an option to SingleListGrader to detect and present an error if there are empty entries in a list, turned on by default.

Includes tests and documentation (I started converting the examples to doctests).

Resolves #167.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b74abb6a854d600480f36585a3534bd166597b24 on emptylist into e218be9e7dbe7fb155ef2b25dd50301fd8bc72b9 on master.

jolyonb commented 5 years ago

I think the problem is worst in SingleListGrader, because it's too easy to have an errant comma. In a ListGrader scenario, it's possible to leave a box empty, but I'm much less worried about that (sometimes it's by design).

jolyonb commented 5 years ago

Implemented your suggestion and updated the documentation properly. Ready for a final review.

Edit: Also pushed docs to server to aid reviewing ;-)