search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

Drop cov #228

Closed ChristopherChudzicki closed 5 years ago

ChristopherChudzicki commented 5 years ago

Just testing that codecov shows a drop in coverage and it's easy to find where from.

(Actually, not a drop, since codecov has no data for master, but at least an uncovered line.)

ChristopherChudzicki commented 5 years ago

I'm confused about why the bot didn't comment here, but the report did get generated:

https://codecov.io/gh/mitodl/mitx-grading-library/commit/9d6151f6fbf1d47d59dfe0562de28bab13aa5b64

ChristopherChudzicki commented 5 years ago

Codecov seems not to recognize that the build passed...

Screen Shot 2019-07-03 at 5 04 12 PM

Well, I'll leave it for a while.

jolyonb commented 5 years ago

Ok, not sure what happened here. Try again in a new PR, now that the base branch has coverage?

jolyonb commented 5 years ago

Also, badges like in the following would be nice :-) https://github.com/TechnionYP5777/SmartCity-Market/wiki/Integrating-Codecov-with-a-GitHub-project-(Coverage-tool)