mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX

https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/

BSD 3-Clause "New" or "Revised" License

14 stars 9 forks source link

Infer answers from expect values for SingleListGrader #252

Closed jolyonb closed 5 years ago

jolyonb commented 5 years ago

This PR generalizes the implementation of reading the expect keyword to infer answers. In particular, it does the following:

Makes it explicit that once an answer is inferred, that answer is stored in the configuration
Ensures that when answers are being inferred, newly-provided expect parameters override the old ones
Adds the inferred answers to the debug log
Generalizes the debug log implementation slightly to provide access to it before the AbstractGrader.__call__ function is called, while ensuring that the log is cleared between calls to a grader
Implements answer inference as a shadowable function
Implements answer inference for SingleListGrader
Implements proper delimiter checking across nested SingleListGraders

jolyonb commented 5 years ago

Also, I found a really neat way to avoid the unicode u issue by using json output!

jolyonb commented 5 years ago

I'm not sure why codecov.io isn't kicking in here?

ChristopherChudzicki commented 5 years ago

@jolyonb Can you resolve merge conflicts on this before review? Sorry for the review backlog =/

jolyonb commented 5 years ago

Rebased and resolved merge conflicts.

codecov-io commented 5 years ago

Codecov Report

Merging #252 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     28    -1     
  Lines        2453   2413   -40     
=====================================
- Hits         2453   2413   -40

jolyonb commented 5 years ago

Ugh, I pushed a wrong branch here... Sorry for the extra messages. Should be all fixed now.

codecov-io commented 5 years ago

Codecov Report

Merging #252 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     28    -1     
  Lines        2453   2413   -40     
=====================================
- Hits         2453   2413   -40

codecov-io commented 5 years ago

Codecov Report

Merging #252 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     29           
  Lines        2453   2479   +26     
=====================================
+ Hits         2453   2479   +26

codecov-io commented 5 years ago

Codecov Report

Merging #252 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     29           
  Lines        2453   2479   +26     
=====================================
+ Hits         2453   2479   +26