mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX

https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/

BSD 3-Clause "New" or "Revised" License

14 stars 9 forks source link

Fixing issue with MatrixGrader voluptuous schema #275

Closed jolyonb closed 5 years ago

jolyonb commented 5 years ago

The schema Any(All(Number, Range(0, 1)), 'proportional') allows True as an input, which evaluates to 1. This caught me out when making an example - it should complain if you give it True, when you probably mean 'proportional' instead.

codecov-io commented 5 years ago

Codecov Report

Merging #275 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          29       29           
  Lines        2600     2600           
=======================================
  Hits         2598     2598           
  Misses          2        2