mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

Finish reformatting of IntegralGrader, implement tests+docs #292

Closed jolyonb closed 4 years ago

jolyonb commented 4 years ago

This splits out the functionality in IntegralGrader that will be duplicated in SumGrader into a base class + subclass implementation. SumGrader should now be straightforward to implement on top of the base class.

This also implements new tests to get coverage back to 100%, and updates the documentation to include all new functionality.

jolyonb commented 4 years ago

Not sure why this isn't generating a message for coverage, but I'm pretty sure it's at 100%.

Ready for review (should be pretty straightforward).

codecov-io commented 4 years ago

Codecov Report

Merging #292 into master will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #292      +/-   ##
===========================================
+ Coverage   99.89%   100.00%   +0.10%     
===========================================
  Files          32        32              
  Lines        2792      2798       +6     
===========================================
+ Hits         2789      2798       +9     
+ Misses          3         0       -3     
jolyonb commented 4 years ago

Ooh, it actually worked! Wonders never cease! (and yes, 100%!)