mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

FormulaGrader comparer key #32

Closed ChristopherChudzicki closed 6 years ago

ChristopherChudzicki commented 6 years ago

Resolves #30

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.004%) to 99.907% when pulling f01df3eb3fdbe9f7eada99f705e308ef5e4a4dd2 on formulagrader-comparer into 3a43a036fd0f8bbcfd8e3c82f1807515b749ea97 on master.

ChristopherChudzicki commented 6 years ago

@jolyonb This is ready for review.

I refactored a few small things in FormulaGrader to increase readability, and would like to refactor a bit more as described in #33

jolyonb commented 6 years ago

This looks really good. I like what you've done here! I've littered some comments throughout the code as one-liners. One extra thing I'd like to see is to add an example of this in action to the edX code.

ChristopherChudzicki commented 6 years ago

@jolyonb I believe all comments are addressed now

jolyonb commented 6 years ago

Do we want to add an example of this to the edX example course? This is kind of a big feature. (We can also do that through a separate PR if you desire.)

ChristopherChudzicki commented 6 years ago

Good point. I'll update the course and make the zip, etc

jolyonb commented 6 years ago

Two more things for the changelog - integralgrader works with complex integrands, and tensor expressions have had some bugs fixed.

jolyonb commented 6 years ago

Finally, README.md has a version number in it.

jolyonb commented 6 years ago

Ok, looks good to me! 😃

jolyonb commented 6 years ago

Can you update the Edge site/close appropriate issues?

ChristopherChudzicki commented 6 years ago

@jolyonb OK, I'm going to import the course on Edge then. (I had been using my own course for testing)