search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

lazily import scipy to avoid import delay #321

Closed drhodes closed 1 year ago

drhodes commented 1 year ago

Addresses #320

jolyonb commented 1 year ago

I did check how codejail interacts with scipy to make sure that scipy isn't being imported anyway; it's not.

jolyonb commented 1 year ago

Aww man, looks like codecov and travis have both broken :( Guess it's time to update the CV/CD pipeline!

jolyonb commented 1 year ago

@drhodes You'll be happy to know that all tests went through successfully on all versions of python :)

jolyonb commented 1 year ago

@drhodes I've created a new version/release/zipfile with this update. It should be ready to use immediately.

drhodes commented 1 year ago

@jolyonb, thank you so much for taking the time out to do this last night, I really appreciate it!

I did check how codejail interacts with scipy to make sure that scipy isn't being imported anyway; it's not.

Good thinking on that! How unfortunate that would have been.

... codecov and travis have both broken :( Guess it's time to update the CV/CD pipeline!

I don't know anything about that stuff, but I really should. If you would like a hand with that, then please let me know. I'd like to start integrating automated checks with some other projects.

Thanks again!