search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

Installation updates #34

Closed ChristopherChudzicki closed 6 years ago

ChristopherChudzicki commented 6 years ago

Today I did a fresh install and created a new virtual environment, which revealed a few issues. This PR:

  1. Fixes some broken tests in test_integralgrader.py. These tests initially used an unexpected keyword argument in pytest's raises() function and so weren't really performing their duty. After pytest 3.5.1, unexpected keyword arguments raise errors.

    (I'm not too familiar with our Travis setup. Does it have a hard-coded pytest version? Or does it use something prior to 3.5.1 by default?)

  2. Includes pylint in requirements.txt.

    We have a .pylintrc file commited, so I think it makes sense to include pylint in the requirements. Plus, on the few occasions I've decided to do a fresh clone, I've consistently forgotten to install pytest on my venv.

  3. Edit: Oh, and pytest changed its cache directory from .cache to .pytest_cache, which I've also changed in the .gitignore

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.907% when pulling 3cec8c9c49661af70f816cee541dbba4506c5e64 on ChristopherChudzicki:installation-updates into 617487ef6ed2efb92b364a20113e595be8940d4a on mitodl:master.