search

mitodl / mitx-grading-library

The MITx Grading Library, a python grading library for edX
https://edge.edx.org/courses/course-v1:MITx+grading-library+examples/
BSD 3-Clause "New" or "Revised" License
14 stars 9 forks source link

Implementing multi-argument functions and fixing exponentiation issue #59

Closed jolyonb closed 6 years ago

jolyonb commented 6 years ago

Addresses issues #42 and #43 by rewriting calc.py to fix exponentiation problem (introduced "negation" operation) and allow multi-argument functions (introduced "arguments" operation). Also did general tidying of pyparsing script and some refactoring of calc.py, along with a little linting. Large changes to your get_number_of_args function were necessary to pull this off.

jolyonb commented 6 years ago

I'm quite proud of this one. Let me know what you think!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fcd152ae5d760b5ccd328a983263813591e9960c on multivar into adaab0c9173f49b26ab404fc404279b13a16d290 on master.

jolyonb commented 6 years ago

Ok, made some minor modifications, and responded to your more major point.

I'm pretty happy that that's all you were able to find, given my 4:30 am coding!