search

mitodl / mitxonline-theme

an open edX theme for MITx Online
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Update edx ACE email template #12

Closed asadiqbal08 closed 3 years ago

asadiqbal08 commented 3 years ago

This email template is used when generating enrollment emails, and probably other transactional emails.

https://github.com/mitodl/mitxonline-theme/blob/main/lms/templates/ace_common/edx_ace/common/base_body.html#L65

acceptance criteria:

image
pdpinch commented 3 years ago

do you have a link or links?

asadiqbal08 commented 3 years ago

I came over this URL under this file. https://github.com/mitodl/mitxonline-theme/blob/main/lms/templates/ace_common/edx_ace/common/base_body.html#L65

asadiqbal08 commented 3 years ago

also the section under the same file have xPro text.

pdpinch commented 3 years ago

I updated the description with some more specific details.

pdpinch commented 3 years ago

Looks like some of these are already fixed on lms-qa. I need to do some more testing.

pdpinch commented 3 years ago

@briangrossman can you review the checklist to see if there's anything further that needs to be done here?

briangrossman commented 3 years ago

@pdpinch & @asadiqbal08

Ran a test. Looks like all these still need to be addressed:

image

asadiqbal08 commented 3 years ago

@pdpinch this ticket is not in the Arbisoft board, should it be ready to work ?

asadiqbal08 commented 3 years ago

@pdpinch can you please looked over this @briangrossman comment

"Access the Course Materials Now" button should work Sorry... I don't see this button. Do you mean the Finish Your Registration button? 'cause that doesn't link anywhere.

asadiqbal08 commented 3 years ago

Ok @briangrossman , What I get, if you have a pending registration then it show the Finish Your Registration button otherwise it shows up the Access the Course Materials Now button.

briangrossman commented 3 years ago

@asadiqbal08

I see. Thanks. I guess we should make sure both cases work. Note that the Finish Your Registration button wasn't linked at all.

asadiqbal08 commented 3 years ago

@pdpinch Referring to this:

Link logo to MITx Online dashboard (on RC, this is https://rc.mitxonline.mit.edu/dashboard) Sign in link should go to MITx Online sign in page (on RC, this is https://rc.mitxonline.mit.edu/signin)

I was trying to update the Sign In and Dashboard URL from the site configuration but the requested changes were not rendering over the email UI and after looking around, I came to know that one of the template context for ACE emails is not being called while sending bulk enrollment emails from instructor dashboard in edx-platform (I am on OPENEDX_RELEASE/lilac.master), Referring this block

There are two possible solutions. 1- Create an upstream PR to call this ace template context for getting extra details in case of enrollments too. OR 2- Used the site_configuration_values in our mitxonline-theme repository as I did in my PR HERE

Let me know do you think and I have these site configurations over my local instance. 

{
  "ENABLE_MKTG_SITE": true,
  "COURSE_CATALOG_API_URL": "http://edx.devstack.discovery:18381/api/v1/",
  "PLATFORM_NAME": "Mitx Online",
  "FOOTER_ORGANIZATION_IMAGE": "images/logo.png",
  "SIGNIN_URL": "/signin",
  "HOMEPAGE_URL": "/dashboard",
  "MKTG_URLS": {
    "ABOUT": "/about-us",
    "CONTACT": "http://mitx-micromasters.zendesk.com/hc/en-us/requests/new",
    "TOS": "/terms-of-service",
    "HONOR": "/honor"
  }
}

Secondly,

"Access the Course Materials Now" button should work

The button is correctly redirecting me towards the course material. Is there any thing related to configuration should I need to check over the MIT QA instance ?

Screen Shot 2021-09-27 at 4 39 33 PM
pdpinch commented 3 years ago

There are two possible solutions. 1- Create an upstream PR to call this ace template context for getting extra details in case of enrollments too. OR 2- Used the site_configuration_values in our mitxonline-theme repository as I did in my PR HERE

Let's go with option 2, since it should be faster and we'd like to fix this before Oct. 1.

Secondly, "Access the Course Materials Now" button should work

It does seem like a misconfiguration somewhere. In the QA stack, the button should like to courses-qa.mitxonline.mit.edu and not lms-qa.mitxonline.mit.edu -- can you determine where that value is being set?

asadiqbal08 commented 3 years ago

It does seem like a misconfiguration somewhere. In the QA stack, the button should like to courses-qa.mitxonline.mit.edu and not lms-qa.mitxonline.mit.edu -- can you determine where that value is being set?

It seems to me, site configuration is not properly set.

Screen Shot 2021-09-28 at 11 53 35 AM
asadiqbal08 commented 3 years ago

@pdpinch are you pointing to From address in this point ?

Return address should be set to "MITx Online" mitxonline-support@mit.edu

pdpinch commented 3 years ago

It seems to me, site configuration is not properly set.

Screen Shot 2021-09-28 at 11 53 35 AM

How do we change this? It looks like a django admin snapshot. What's the URL? (fyi @briangrossman )

pdpinch commented 3 years ago

@pdpinch are you pointing to From address in this point ?

Return address should be set to "MITx Online" mitxonline-support@mit.edu

Yes, I'm referring to the From address.

asadiqbal08 commented 3 years ago

It seems to me, site configuration is not properly set.

Screen Shot 2021-09-28 at 11 53 35 AM

How do we change this? It looks like a django admin snapshot. What's the URL? (fyi @briangrossman )

Yes it is site admin and the screenshot is referring this site_configuration