mitodl / mitxonline

BSD 3-Clause "New" or "Revised" License
4 stars 2 forks source link

4545 mitx online program drawercourse upgrade formatting #2256

Closed collinpreston closed 3 weeks ago

collinpreston commented 1 month ago

What are the relevant tickets?

https://github.com/mitodl/hq/issues/4545

Description (What does it do?)

Fixes the upgrade button formatting on the program drawer

Screenshots (if appropriate):

Screenshot 2024-06-14 at 8 10 12 AM

How can this be tested?

  1. Enroll into a program.
  2. Go to your dashboard, then program tab, then click on the program.
  3. Verify that the "Get certificate" button is formatted under the text for any required course.
  4. Verify that the formatting of the same button is unchanged when viewing the course on the course tab of the dashboard.
annagav commented 1 month ago

Looks good! Just one minor thing: could we put "Get Certificate" text in the button into one line?

Screenshot 2024-06-17 at 9 40 40 AM
collinpreston commented 1 month ago

Looks good! Just one minor thing: could we put "Get Certificate" text in the button into one line? Screenshot 2024-06-17 at 9 40 40 AM

I tried resolving this, but it seems that the button text is two lines due to padding and the size of the font when the page is in a medium sized viewport.

collinpreston commented 1 month ago

Looks good! Just one minor thing: could we put "Get Certificate" text in the button into one line? Screenshot 2024-06-17 at 9 40 40 AM

I tried resolving this, but it seems that the button text is two lines due to padding and the size of the font when the page is in a medium sized viewport.

@mbilalmughal do you know how the text on this button should be formatted?

annagav commented 1 month ago

@mbilalmughal Could you help us find the UI design for this view? The button and the text don't fit very nicely when the width of the window is changing:

Screenshot 2024-06-17 at 1 08 31 PM
mbilalmughal commented 3 weeks ago

@collinpreston @annagav Here is the mobile / Smaller screen UI for the dashboard

I've noticed that without designing a smaller screen UI, it won't be possible to suggest appropriate solutions to the problem or adjust the content properly.

Spacing guidelines image