Dashboard shouldn't lnk to a course that hasn't started

mitodl / mitxonline

BSD 3-Clause "New" or "Revised" License

4 stars 2 forks source link

Dashboard shouldn't lnk to a course that hasn't started #932

Open pdpinch opened 2 years ago

pdpinch commented 2 years ago

Steps to Reproduce

Enroll in a course with a start date in the future
Click the course title in the dashboard

Expected Behavior

The course title should be a link when the course hasn't started. There's no place to go yet.
It might be nice to have some kind of message if the user does click on the course -- e.g. "Course starts xx/yy/zz at time" -- but I don't think we have an appropriate design at this time.

Actual Behavior

link goes to open edX
open edX redirects to the open edX dashboard

jkachel commented 2 years ago

Testing this on rc with apptest+20220902@jkachel.com and can't reproduce - the code that determines if the title should be linkable already considers the course's start date. I enrolled in Test External Course and set the start date to 2023 and I don't get a link in the card. Is there an account I can use that's doing this?

arslanashraf7 commented 2 years ago

Just adding more to what @jkachel mentioned, I think when a user is logged in through staff/admin account they still see the link even when the link will be disabled for learners. I think we intentionally did it at some point in https://github.com/mitodl/mitxonline/pull/207.