Catalog CMS Page performance degradation

mitodl / mitxpro

BSD 3-Clause "New" or "Revised" License

11 stars 2 forks source link

Catalog CMS Page performance degradation #2530

Open asadali145 opened 1 year ago

asadali145 commented 1 year ago

Steps to Reproduce

Check out the master branch.
Make sure that you have enough data for the Catalog page.
Visit the catalog page.
Monitor /silk/requests/. N+1 queries are done on the DB.

Expected Behavior

No N+1 queries as we already optimized the Catalog page under https://github.com/mitodl/mitxpro/pull/2487

Actual Behavior

N+1 queries

Screenshot or Screencast

arslanashraf7 commented 10 months ago

@asadali145 Should we close this?

asadali145 commented 10 months ago

We can close and can also work on the identified improvement if we want to. Not sure about the priority.

arslanashraf7 commented 10 months ago

Oh, We need to get https://github.com/mitodl/mitxpro/pull/2531 merged for that right?

asadali145 commented 10 months ago

Yeah, The draft PR kind of adds some improvements but Nathan suggested trying another package. Haven't worked on the PR as the issue was resolved and I got busy with other stuff.