Pre commit linting - Githubissues

mitodl / mitxpro

BSD 3-Clause "New" or "Revised" License

12 stars 2 forks source link

Pre commit linting #2955

Closed blarghmatey closed 4 months ago

blarghmatey commented 4 months ago

What are the relevant tickets?

N/A

Description (What does it do?)

Adds a comprehensive pre-commit configuration to the repository to help enforce quality and style standards.

How can this be tested?

Check out the branch, install the pre-commit CLI and install the hooks, then run pre-commit run --all-files

Additional Context

This is a follow-on to https://github.com/mitodl/hq/discussions/2993 and https://github.com/mitodl/hq/discussions/1422

gitguardian[bot] commented 4 months ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

asadali145 commented 4 months ago

@blarghmatey You will have to rebase this as I merged a ruff upgrade PR today.

blarghmatey commented 4 months ago

Thanks @asadali145. I've rebased against master and all checks are passing.

blarghmatey commented 4 months ago

Thanks @asadali145 I've rebased again from master. Looks like the checks are passing still if you can give another review and approval (assuming you're happy with it).

asadali145 commented 4 months ago

@blarghmatey ruff is still failing locally. Could you check?