style: add trademark logos

mitodl / mitxpro

BSD 3-Clause "New" or "Revised" License

12 stars 2 forks source link

style: add trademark logos #3176

Closed arslanashraf7 closed 1 week ago

arslanashraf7 commented 1 week ago

What are the relevant tickets?

https://github.com/mitodl/hq/issues/5719

Description (What does it do?)

Adds the trademark logos

Screenshots (if appropriate):

Certificate (Desktop)

Certificate (Mobile)

Dashboard (Desktop)

Dashboard (Mobile)

Emails

How can this be tested?

Setup xPRO on this branch
Verify that the application shows trademark logos everywhere e.g. Signup/Login, Dashboard, Course Page, Registration/enrollment Emails

arslanashraf7 commented 1 week ago

@mbilalmughal, I added the logs provided at https://github.com/mitodl/hq/issues/5719#issuecomment-2396391774. There are screenshots attached to this PR description. I think the trademark R looks too small, almost like a dot. What do you think ?

mbilalmughal commented 1 week ago

@arslanashraf7 LGTM as per the logos provided here, but you’re right in terms of visuals, it looks is too small.

I think we should show it to the branding team and request that they resize the 'R' slightly so it will be more visible.

arslanashraf7 commented 1 week ago

@cachob @pdpinch What's your opinion on screenshots?

cachob commented 1 week ago

@arslanashraf7 - it's what has been provided and assumed approved so we need to stick with the logo for now. I believe the main objective here is to have a logo with the trademark on public display per USPTO guidelines to protect us legally. We can fix the aesthetic later on

arslanashraf7 commented 1 week ago

Maybe we should change the Zendesk logo as well?

Good question. @cachob what do you suggest?