mitodl / ocw-data-parser

A parsing script for MIT OpenCourseWare course data
0 stars 0 forks source link

CHP is missing Learning Resource Type "Video Lectures" #161

Open pdpinch opened 2 years ago

pdpinch commented 2 years ago

Steps to Reproduce

Compare legacy: https://ocw.mit.edu/courses/electrical-engineering-and-computer-science/6-036-introduction-to-machine-learning-fall-2020/ nextgen: 6-036-introduction-to-machine-learning-fall-2020/

nextgen raw json: s3://ocw-content-storage/PROD/6/6.036/Fall_2020/6-036-introduction-to-machine-learning-fall-2020/0/1.json nextgen parsed json: s3://open-learning-course-data-production/6-036-introduction-to-machine-learning-fall-2020/6-036-introduction-to-machine-learning-fall-2020_parsed.json

Expected Behavior

There should be a Learning Resource Type of "Lecture Videos"

Actual Behavior

There are no learning resource types

pdpinch commented 2 years ago

It seems that the raw json contains only one course feature, "AV lectures"

    "feature_requirements": [
        {
            "ocw_feature": "AV lectures", 
            "ocw_subfeature": "Video", 
            "ocw_feature_url": "https://openlearninglibrary.mit.edu/courses/course-v1:MITx+6.036+1T2019/about", 
            "ocw_speciality": "", 
            "ocw_feature_notes": ""
        }

but it's not making it into the parsed json:

  "course_features": [], 
mbertrand commented 2 years ago

This is because the ocw_feature_url points to an external URL. Course features are added only if the feature's linked page is within the course's internal pages. I can change this if you think it is appropriate to do so. @pdpinch @gumaerc

pdpinch commented 1 year ago

I think it was a mistake to skip over importing those links. We'll probably need to revisit this some day.