search

mitodl / ocw-hugo-themes

A Hugo theme for building OCW websites
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

fix: main section layout #1232

Closed HussainTaj-arbisoft closed 1 year ago

HussainTaj-arbisoft commented 1 year ago

What are the relevant tickets?

Fixes a side effect of https://github.com/mitodl/ocw-hugo-themes/pull/1228

Description (What does it do?)

Fixes a side effect of https://github.com/mitodl/ocw-hugo-themes/pull/1228

Some elements in the main section do not behave well without the main section having a defined width. See screenshots for examples.

Screenshots (if appropriate):

Before

Screenshot 2023-08-25 at 3 56 13 PM

After

Screenshot 2023-08-25 at 3 56 29 PM

How can this be tested?

  1. Grab any course content from ocw-content-rc and place it inside your local content directory.
  2. Navigate to your local setup of ocw-hugo-themes and check the branch hussaintaj/fix-main-section-layout.
  3. Run 
    yarn start course <course-dir-name>
  4. Visit any page other than the homepage.
  5. Toggle course info and see if different pages behave correctly i.e. video page, video gallery pages etc.
github-actions[bot] commented 1 year ago

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1232--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1232--ocw-next.netlify.app/