mitodl / ocw-hugo-themes

A Hugo theme for building OCW websites
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

swap out chromium for google chrome and firefox in playwright tests #1281

Closed gumaerc closed 1 year ago

gumaerc commented 1 year ago

What are the relevant tickets?

Closes https://github.com/mitodl/ocw-hugo-themes/issues/1279

Description (What does it do?)

The "Transcripts start time matches video start time" test in video.spec.ts loads a video that started refusing to play in the Chromium browser, which Playwright uses on the backend to run its tests. This PR switches out the Chromium browser for Google Chrome and Firefox, which seem to run the test fine.

How can this be tested?

github-actions[bot] commented 1 year ago

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1281--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1281--ocw-next.netlify.app/

gumaerc commented 1 year ago

@ibrahimjaved12 I reverted this PR to use the original video from the test and swapped out the browsers being used for testing, since Chromium is being problematic with videos.

ibrahimjaved12 commented 1 year ago

We decided that we will deal with those playwright tests separately in a different ticket(s) - because the purpose of this PR is to pass the currently failing CI test. And this PR does that - it's safe to deploy it as those locally failing playwright tests are specifically because of Mac OS being used with firefox.