Closed HussainTaj-arbisoft closed 8 months ago
Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1298--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1298--ocw-next.netlify.app/
@gumaerc this PR is ready for another look.
The most significant changes since you last saw this PR are:
link
to external-resource
.is_image
property.menuItem.pageRef
instead of menuItem.url
. You may see the relevant docs here.Right now we're going with the default UI. There is a potential for a new UI in https://github.com/mitodl/hq/issues/3416 but no solid decision has been made yet. I haven't removed the new external_resource_link
shortcode from this PR in anticipation of a new UI component, but let me know if you think we should remove it until it's needed.
I've added some new data for the tests. https://github.com/mitodl/ocw-studio/pull/2116 updates the fixtures. It would be great if you could look at that too.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/3405
Description (What does it do?)
This PR:
external_resource_link
shortcode.resource_link
shortcode to uniquely handleexternal-resource
type content.external-resource
content (google.com
) instead of rendering a link to the content page (i.e./links/google
).We will keep the
external_resource_link
shortcode orresource_link
changes. It depends on what we decide in https://github.com/mitodl/hq/issues/3416.If a new UI element (CKEditor plugin) is to be created, we'll go with the
external_resource_link
shortcode, making things less complicated.Screenshots (if appropriate):
https://github.com/mitodl/ocw-hugo-themes/assets/71316217/0bc23776-6cb3-4d4a-a14e-32cffa55ec3e
How can this be tested?
Prerequisites
Steps
ocw-content
directory.ocw-hugo-themes
directory.hussaintaj/3358-link-shortcode
.Additional Context
https://github.com/mitodl/hq/issues/3358
Checklist
Before merging this change: