search

mitodl / ocw-hugo-themes

A Hugo theme for building OCW websites
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

fix: search page (broken by ramda upgrade) #1360

Closed HussainTaj-arbisoft closed 8 months ago

HussainTaj-arbisoft commented 9 months ago

What are the relevant tickets?

PR: https://github.com/mitodl/ocw-hugo-themes/pull/1347 Ramda Release Notes: https://github.com/ramda/ramda/issues/3218

Description (What does it do?)

https://github.com/mitodl/ocw-hugo-themes/pull/1347 auto updates ramda from 0.27 to 0.29. In 0.28, the method contains was removed in favor of includes.

How can this be tested?

  1. Navigate to your local ocw-hugo-themes directory.
  2. Checkout the branch hussaintaj/fix-search-ramda.
  3. Make sure your env has 
    STATIC_API_BASE_URL=https://live-qa.ocw.mit.edu/
  4. Run 
    yarn start www
  5. Open localhost:3000/search with CORS disabled.

    I use an extension called "CORS Everywhere" in firefox.

  6. Expect the search to work. Especially the filter facets.
github-actions[bot] commented 9 months ago

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1360--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1360--ocw-next.netlify.app/