search

mitodl / ocw-hugo-themes

A Hugo theme for building OCW websites
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Fix resource list top border styling #1366

Closed ibrahimjaved12 closed 8 months ago

ibrahimjaved12 commented 8 months ago

What are the relevant tickets?

No ticket

Description (What does it do?)

Fixes border-top styling not being applied to resource lists. For example: https://ocw.mit.edu/courses/21a-505j-the-anthropology-of-sound-spring-2022/lists/lecture-slides/ https://draft.ocw.mit.edu/courses/3-020-thermodynamics-of-materials-spring-2021/lists/problem-sets/

It should be like the lists here: https://ocw.mit.edu/courses/res-18-010-a-2020-vision-of-linear-algebra-spring-2020/download/

Screenshots (Before & After):

image image

How can this be tested?

  1. Checkout to this branch
  2. Run yarn start course 21A.505J-spring-2022
  3. Go to http://localhost:3000/ and lecture slides from left menu
  4. See the top-border is being applied to first element
  5. Go to download course from http://localhost:3000/, see the borders are being applied on lists there Another good example of a course is 18.06sc-fall-2011. Run it locally, go to Download Course. From there see the lists that have "See all" option, click it, and see the lists still have consistent styling.

For offline course theme, run: yarn build ~/path/ocw-content-rc/3.020-spring-2021/ ~/path/ocw-hugo-projects/ocw-course-v2/config-offline.yaml And then open index.html from dist directory of the course.

github-actions[bot] commented 8 months ago

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1366--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1366--ocw-next.netlify.app/