Render external resources in www theme

mitodl / ocw-hugo-themes

A Hugo theme for building OCW websites

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

Render external resources in www theme #1412

Closed ibrahimjaved12 closed 4 months ago

ibrahimjaved12 commented 5 months ago

What are the relevant tickets?

Task 2: https://github.com/mitodl/hq/issues/4245

Description (What does it do?)

Render external resources in www theme by calling the external_link_modal partial in www/layouts/_default/baseof.html.

How can this be tested?

Testing instructions given in https://github.com/mitodl/ocw-hugo-projects/pull/296 Test both PRs together.

github-actions[bot] commented 5 months ago

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1412--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1412--ocw-next.netlify.app/

ibrahimjaved12 commented 5 months ago

This PR is completed but on hold until these changes are working as expected: https://github.com/mitodl/hq/issues/4189 (to make sure there is no side effect in testing)