mitodl / ocw-studio

Open Source Courseware authoring tool
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

fix: increase timeout for e2e tests #2128

Closed HussainTaj-arbisoft closed 4 months ago

HussainTaj-arbisoft commented 4 months ago

What are the relevant tickets?

Relates to https://github.com/mitodl/ocw-studio/pull/2125

Description (What does it do?)

I recently updated e2e tests and the RC pipeline keeps timing out on the playwright-task task. Upon running the pipeline locally, I faced a similar issue a few times, and increasing the timeout fixed it. I believe the issue is related to limited resources/bandwidth.

Each test has a timeout of 60 seconds and we have 80 test at the moment. I've chosen a 2h timeout based on the rule:

task_timeout > max_playwright_timeout_all_tests + buffer (for browser installation and such)

How can this be tested?

  1. Navigate to your local ocw-studio directory.
  2. Checkout the branch hussaintaj/increase-e2e-test-timeout.
  3. Start/Restart Studio.
  4. Run
    docker compose exec web ./manage.py upsert_e2e_test_pipeline 
  5. Open your concourse and trigger a build.
  6. Expect the pipeline to finish without a timeout.

    We're not looking for the tests to pass. We just want to make sure it doesn't timeout. You will need to have the ci courses in your git backend.