search

mitodl / ocw-studio

Open Source Courseware authoring tool
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

upgraded PostgreSQL version from 12.8 to 16.3 #2184

Closed umar8hassan closed 4 months ago

umar8hassan commented 4 months ago

What are the relevant tickets?

This closes https://github.com/mitodl/hq/issues/4323

Description (What does it do?)

PostgreSQL version upgrade from 12.8 to 16.3. Follow instructions in https://github.com/mitodl/hq/issues/4323 to migrate data locally (if required)

How can this be tested?

  1. Restart Containers with the following commands, and check if ocw-studio is running:
    • docker-compose down
    • docker-compose up -d
blarghmatey commented 4 months ago

This will also need to include an update to the GH workflow here to ensure that the tests are using the proper version of the database.

umar8hassan commented 4 months ago

This will also need to include an update to the GH workflow here to ensure that the tests are using the proper version of the database.

Thanks @blarghmatey for taking time to review this. This would have been our next step as mentioned in https://github.com/mitodl/hq/issues/4242.

arslanashraf7 commented 4 months ago

I know this has been merged but just want to leave some thoughts for the future. This is not urgent but could be useful I the future:

  1. @ibrahimjaved12 Please change the PR level from Needs Review to Waiting on Author once the PR has been reviewed
  2. I agree with @blarghmatey's comment above and we should have done the CI upgrade in this PR even if there were two separate issues written for that because:
    • The CI script is for GitHub Actions and ideally the local and the GitHub Actions CI changes should be in sync through a PR
    • If we hit an unfortunate situation where we would have to revert the Postgres upgrade, It would be easier to revert this change through a single revert commit instead of multiple comments.